Conversation
martinpitt
added a commit
to martinpitt/lsr-sudo
that referenced
this pull request
Apr 15, 2025
martinpitt
force-pushed
the
retry-image-download
branch
from
30779ef to
2c45b0a
Compare
martinpitt
added a commit
to martinpitt/lsr-sudo
that referenced
this pull request
Apr 15, 2025
martinpitt
force-pushed
the
retry-image-download
branch
2 times, most recently
from
b3818f6 to
ecd6cca
Compare
Contributor
Author
|
Meh, flake8 is really being annoying here.. |
Introduce a `urlopen_retry()` wrapper that retries up to 4 times with exponential back-off. This avoids failing tests due to short network glitches on the Fedora/CentOS image servers. Replace the two non-context urlopen() calls with contexts.
martinpitt
force-pushed
the
retry-image-download
branch
from
ecd6cca to
b1c2120
Compare
martinpitt
added a commit
to martinpitt/lsr-sudo
that referenced
this pull request
Apr 15, 2025
richm
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
urlopen_retry()wrapper that retries up to 4 times with exponential back-off. This avoids failing tests due to short network glitches on the Fedora/CentOS image servers.Replace the two non-context urlopen() calls with contexts.
Avoids failures like this and this. I tested this locally by temporarily damaging the download URL in ~/.config/linux-system-roles.json :
also tested with Fedora, and of course the passing cases. I sent a draft PR against sudo to validate this against CI, as this is a bit difficult to test locally with Python 2.7: linux-system-roles/sudo#49